Re: [PATCH 5/5] hw/audio/via-ac97: Basic implementation of audio playback

[Daniel Henrique Barboza]

On 2/24/23 18:08, BALATON Zoltan wrote:
> On Fri, 24 Feb 2023, Daniel Henrique Barboza wrote:
> > On 2/24/23 10:05, BALATON Zoltan wrote:
> > > Just for some motivation, this is what we want to make possible for more people 
> > > with QEMU 8.0: https://youtu.be/YY9RExl4VDI
> >
> > That's neat!
> >
> > > This would need at least my SM502 patches and fixing the IRQ routing in the 
> > > VT8231 (this test was with my series for that, I'll ask testing Bernhard's 
> > > version the same way once I get it and rebase my patches on it). AmigaOS can 
> > > use ES1370 so the via-ac97 patches are not that important now but the other 
> > > patches would be needed. I hope users won't have to wait until September to try 
> > > this.
> >
> > If you're referring to "hw/display/sm501: Implement more 2D raster operations" 
> > then it's already
> > queued in ppc-next.
>
> That one and another I've sent yesterday that adds fallbacks for pixman 
> routines.
>
> > In fact I believe you can re-send it with this series, with my r-b, and whoever
> > gets to send the PR can send everything at once.
>
> OK I'll collect all the patches in one series and submit it early next week. 
> Hopefully we can test over the weekend and address any comments by the freeze.

Yes please.

> > If either Gerd of Phil wants to pick these up I have already acked the pegasos2 
> > changes.
> >
> > If you want me to get this via qemu-ppc bear in mind that I need to send the PR 
> > March 7th
> > at the latest.
>
> I'm aware of that, although if we get more CI outage which stops pulls maybe we 
> should consider 1-2 week extension, but I'm planning accordingly and if there 
> won't be unexpected delays (e.g. new late reviews asking for extensive changes) 
> this should be ready a week before the freeze. I think we can do one or two 
> more versions/

It's no possible to predict this kind of unexpected delay, yes. But in the end 
the
maintainer is here to mediate these situations. If the patches have acks and the
maintainer considered it worth pushing, then this late review must be so good 
that
it convinces the maintainer to drop the patches from the PR (and from the 
release,
in this case).

It can happen, sure, but it's not a given. Specially considering that we have a 
good
code freeze window to fix any bugs that we might have left behind during the 
development
cycle.


Thanks,


Daniel

> Regards,
> BALATON Zoltan