[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 62/76] target/s390x: Remove assert vs g_in2
From: |
Richard Henderson |
Subject: |
[PATCH v2 62/76] target/s390x: Remove assert vs g_in2 |
Date: |
Sun, 26 Feb 2023 19:24:51 -1000 |
These were trying to determine if o->in2 was available for
use as a temporary. It's better to just allocate a new one.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/tcg/translate.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index beccd3429e..c431903c67 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -1428,11 +1428,11 @@ static DisasJumpType op_andi(DisasContext *s, DisasOps
*o)
int shift = s->insn->data & 0xff;
int size = s->insn->data >> 8;
uint64_t mask = ((1ull << size) - 1) << shift;
+ TCGv_i64 t = tcg_temp_new_i64();
- assert(!o->g_in2);
- tcg_gen_shli_i64(o->in2, o->in2, shift);
- tcg_gen_ori_i64(o->in2, o->in2, ~mask);
- tcg_gen_and_i64(o->out, o->in1, o->in2);
+ tcg_gen_shli_i64(t, o->in2, shift);
+ tcg_gen_ori_i64(t, t, ~mask);
+ tcg_gen_and_i64(o->out, o->in1, t);
/* Produce the CC from only the bits manipulated. */
tcg_gen_andi_i64(cc_dst, o->out, mask);
@@ -3520,10 +3520,10 @@ static DisasJumpType op_ori(DisasContext *s, DisasOps
*o)
int shift = s->insn->data & 0xff;
int size = s->insn->data >> 8;
uint64_t mask = ((1ull << size) - 1) << shift;
+ TCGv_i64 t = tcg_temp_new_i64();
- assert(!o->g_in2);
- tcg_gen_shli_i64(o->in2, o->in2, shift);
- tcg_gen_or_i64(o->out, o->in1, o->in2);
+ tcg_gen_shli_i64(t, o->in2, shift);
+ tcg_gen_or_i64(o->out, o->in1, t);
/* Produce the CC from only the bits manipulated. */
tcg_gen_andi_i64(cc_dst, o->out, mask);
@@ -4832,10 +4832,10 @@ static DisasJumpType op_xori(DisasContext *s, DisasOps
*o)
int shift = s->insn->data & 0xff;
int size = s->insn->data >> 8;
uint64_t mask = ((1ull << size) - 1) << shift;
+ TCGv_i64 t = tcg_temp_new_i64();
- assert(!o->g_in2);
- tcg_gen_shli_i64(o->in2, o->in2, shift);
- tcg_gen_xor_i64(o->out, o->in1, o->in2);
+ tcg_gen_shli_i64(t, o->in2, shift);
+ tcg_gen_xor_i64(o->out, o->in1, t);
/* Produce the CC from only the bits manipulated. */
tcg_gen_andi_i64(cc_dst, o->out, mask);
--
2.34.1
- [PATCH v2 52/76] target/riscv: Drop temp_new, (continued)
- [PATCH v2 52/76] target/riscv: Drop temp_new, Richard Henderson, 2023/02/27
- [PATCH v2 53/76] target/riscv: Drop tcg_temp_free, Richard Henderson, 2023/02/27
- [PATCH v2 48/76] target/nios2: Drop tcg_temp_free, Richard Henderson, 2023/02/27
- [PATCH v2 54/76] target/rx: Drop tcg_temp_free, Richard Henderson, 2023/02/27
- [PATCH v2 55/76] target/s390x: Use tcg_constant_* in local contexts, Richard Henderson, 2023/02/27
- [PATCH v2 57/76] target/s390x: Use tcg_constant_i32 for fpinst_extract_m34, Richard Henderson, 2023/02/27
- [PATCH v2 59/76] target/s390x: Drop free_compare, Richard Henderson, 2023/02/27
- [PATCH v2 58/76] target/s390x: Use tcg_constant_* in translate_vx.c.inc, Richard Henderson, 2023/02/27
- [PATCH v2 60/76] target/s390x: Drop tcg_temp_free from translate_vx.c.inc, Richard Henderson, 2023/02/27
- [PATCH v2 61/76] target/s390x: Drop tcg_temp_free from translate.c, Richard Henderson, 2023/02/27
- [PATCH v2 62/76] target/s390x: Remove assert vs g_in2,
Richard Henderson <=
- [PATCH v2 64/76] target/sh4: Drop tcg_temp_free, Richard Henderson, 2023/02/27
- [PATCH v2 65/76] target/sparc: Drop get_temp_tl, Richard Henderson, 2023/02/27
- [PATCH v2 68/76] target/sparc: Drop free_compare, Richard Henderson, 2023/02/27
- [PATCH v2 69/76] target/sparc: Drop tcg_temp_free, Richard Henderson, 2023/02/27
- [PATCH v2 63/76] target/s390x: Remove g_out, g_out2, g_in1, g_in2 from DisasContext, Richard Henderson, 2023/02/27
- [PATCH v2 71/76] target/xtensa: Drop reset_sar_tracker, Richard Henderson, 2023/02/27
- [PATCH v2 73/76] include/exec/gen-icount: Drop tcg_temp_free in gen_tb_start, Richard Henderson, 2023/02/27
- [PATCH v2 75/76] tcg: Create tcg/tcg-temp-internal.h, Richard Henderson, 2023/02/27
- [PATCH v2 66/76] target/sparc: Drop get_temp_i32, Richard Henderson, 2023/02/27
- [PATCH v2 67/76] target/sparc: Remove egress label in disas_sparc_context, Richard Henderson, 2023/02/27