Re: [PATCH 03/13] hw/isa/vt82c686: Remove via_isa_set_irq()

[Mark Cave-Ayland]

On 22/04/2023 16:07, Bernhard Beschow wrote:

> Now that via_isa_set_irq() is unused it can be removed.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   include/hw/isa/vt82c686.h | 2 --
>   hw/isa/vt82c686.c         | 6 ------
>   2 files changed, 8 deletions(-)
>
> diff --git a/include/hw/isa/vt82c686.h b/include/hw/isa/vt82c686.h
> index da1722daf2..b6e95b2851 100644
> --- a/include/hw/isa/vt82c686.h
> +++ b/include/hw/isa/vt82c686.h
> @@ -34,6 +34,4 @@ struct ViaAC97State {
>       uint32_t ac97_cmd;
>   };
>   
> -void via_isa_set_irq(PCIDevice *d, int n, int level);
> -
>   #endif
> diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
> index c7e29bb46a..a69888a396 100644
> --- a/hw/isa/vt82c686.c
> +++ b/hw/isa/vt82c686.c
> @@ -604,12 +604,6 @@ static const TypeInfo via_isa_info = {
>       },
>   };
>   
> -void via_isa_set_irq(PCIDevice *d, int n, int level)
> -{
> -    ViaISAState *s = VIA_ISA(d);
> -    qemu_set_irq(s->isa_irqs_in[n], level);
> -}
> -
>   static void via_isa_request_i8259_irq(void *opaque, int irq, int level)
>   {
>       ViaISAState *s = opaque;

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.