[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/6] target/riscv: Add disas support for BF16 extensions
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH v2 6/6] target/riscv: Add disas support for BF16 extensions |
|
Date: |
Mon, 3 Jul 2023 13:08:55 +1000 |
On Thu, Jun 15, 2023 at 4:36 PM Weiwei Li <liweiwei@iscas.ac.cn> wrote:
>
> Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
> Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
I have applied the first 5 patches, do you mind rebasing this patch
and resending it?
Alistair
> ---
> disas/riscv.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/disas/riscv.c b/disas/riscv.c
> index 5005364aba..44ea69315c 100644
> --- a/disas/riscv.c
> +++ b/disas/riscv.c
> @@ -964,6 +964,16 @@ typedef enum {
> rv_op_cm_jalt = 788,
> rv_op_czero_eqz = 789,
> rv_op_czero_nez = 790,
> + rv_op_fcvt_bf16_s = 791,
> + rv_op_fcvt_s_bf16 = 792,
> + rv_op_vfncvtbf16_f_f_w = 793,
> + rv_op_vfwcvtbf16_f_f_v = 794,
> + rv_op_vfwmaccbf16_vv = 795,
> + rv_op_vfwmaccbf16_vf = 796,
> + rv_op_flh = 797,
> + rv_op_fsh = 798,
> + rv_op_fmv_h_x = 799,
> + rv_op_fmv_x_h = 800,
> } rv_op;
>
> /* structures */
> @@ -2168,6 +2178,16 @@ const rv_opcode_data opcode_data[] = {
> { "cm.jalt", rv_codec_zcmt_jt, rv_fmt_zcmt_index, NULL, 0 },
> { "czero.eqz", rv_codec_r, rv_fmt_rd_rs1_rs2, NULL, 0, 0, 0 },
> { "czero.nez", rv_codec_r, rv_fmt_rd_rs1_rs2, NULL, 0, 0, 0 },
> + { "fcvt.bf16.s", rv_codec_r_m, rv_fmt_rm_frd_frs1, NULL, 0, 0, 0 },
> + { "fcvt.s.bf16", rv_codec_r_m, rv_fmt_rm_frd_frs1, NULL, 0, 0, 0 },
> + { "vfncvtbf16.f.f.w", rv_codec_v_r, rv_fmt_vd_vs2_vm, NULL, 0, 0, 0 },
> + { "vfwcvtbf16.f.f.v", rv_codec_v_r, rv_fmt_vd_vs2_vm, NULL, 0, 0, 0 },
> + { "vfwmaccbf16.vv", rv_codec_v_r, rv_fmt_vd_vs1_vs2_vm, NULL, 0, 0, 0 },
> + { "vfwmaccbf16.vf", rv_codec_v_r, rv_fmt_vd_fs1_vs2_vm, NULL, 0, 0, 0 },
> + { "flh", rv_codec_i, rv_fmt_frd_offset_rs1, NULL, 0, 0, 0 },
> + { "fsh", rv_codec_s, rv_fmt_frs2_offset_rs1, NULL, 0, 0, 0 },
> + { "fmv.h.x", rv_codec_r, rv_fmt_frd_rs1, NULL, 0, 0, 0 },
> + { "fmv.x.h", rv_codec_r, rv_fmt_rd_frs1, NULL, 0, 0, 0 },
> };
>
> /* CSR names */
> @@ -2643,6 +2663,7 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa
> isa)
> case 3: op = rv_op_vloxei8_v; break;
> }
> break;
> + case 1: op = rv_op_flh; break;
> case 2: op = rv_op_flw; break;
> case 3: op = rv_op_fld; break;
> case 4: op = rv_op_flq; break;
> @@ -2846,6 +2867,7 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa
> isa)
> case 3: op = rv_op_vsoxei8_v; break;
> }
> break;
> + case 1: op = rv_op_fsh; break;
> case 2: op = rv_op_fsw; break;
> case 3: op = rv_op_fsd; break;
> case 4: op = rv_op_fsq; break;
> @@ -3123,6 +3145,7 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa
> isa)
> switch ((inst >> 20) & 0b11111) {
> case 1: op = rv_op_fcvt_s_d; break;
> case 3: op = rv_op_fcvt_s_q; break;
> + case 6: op = rv_op_fcvt_s_bf16; break;
> }
> break;
> case 33:
> @@ -3131,6 +3154,11 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa
> isa)
> case 3: op = rv_op_fcvt_d_q; break;
> }
> break;
> + case 34:
> + switch (((inst >> 20) & 0b11111)) {
> + case 8: op = rv_op_fcvt_bf16_s; break;
> + }
> + break;
> case 35:
> switch ((inst >> 20) & 0b11111) {
> case 0: op = rv_op_fcvt_q_s; break;
> @@ -3235,6 +3263,12 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa
> isa)
> case 1: op = rv_op_fclass_d; break;
> }
> break;
> + case 114:
> + switch (((inst >> 17) & 0b11111000) |
> + ((inst >> 12) & 0b00000111)) {
> + case 0: op = rv_op_fmv_x_h; break;
> + }
> + break;
> case 115:
> switch (((inst >> 17) & 0b11111000) |
> ((inst >> 12) & 0b00000111)) {
> @@ -3254,6 +3288,12 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa
> isa)
> case 0: op = rv_op_fmv_d_x; break;
> }
> break;
> + case 122:
> + switch (((inst >> 17) & 0b11111000) |
> + ((inst >> 12) & 0b00000111)) {
> + case 0: op = rv_op_fmv_h_x; break;
> + }
> + break;
> case 123:
> switch (((inst >> 17) & 0b11111000) |
> ((inst >> 12) & 0b00000111)) {
> @@ -3350,6 +3390,7 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa
> isa)
> case 10: op = rv_op_vfwcvt_f_xu_v; break;
> case 11: op = rv_op_vfwcvt_f_x_v; break;
> case 12: op = rv_op_vfwcvt_f_f_v; break;
> + case 13: op = rv_op_vfwcvtbf16_f_f_v; break;
> case 14: op = rv_op_vfwcvt_rtz_xu_f_v; break;
> case 15: op = rv_op_vfwcvt_rtz_x_f_v; break;
> case 16: op = rv_op_vfncvt_xu_f_w; break;
> @@ -3360,6 +3401,7 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa
> isa)
> case 21: op = rv_op_vfncvt_rod_f_f_w; break;
> case 22: op = rv_op_vfncvt_rtz_xu_f_w; break;
> case 23: op = rv_op_vfncvt_rtz_x_f_w; break;
> + case 29: op = rv_op_vfncvtbf16_f_f_w; break;
> }
> break;
> case 19:
> @@ -3391,6 +3433,7 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa
> isa)
> case 52: op = rv_op_vfwadd_wv; break;
> case 54: op = rv_op_vfwsub_wv; break;
> case 56: op = rv_op_vfwmul_vv; break;
> + case 59: op = rv_op_vfwmaccbf16_vv; break;
> case 60: op = rv_op_vfwmacc_vv; break;
> case 61: op = rv_op_vfwnmacc_vv; break;
> case 62: op = rv_op_vfwmsac_vv; break;
> @@ -3629,6 +3672,7 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa
> isa)
> case 52: op = rv_op_vfwadd_wf; break;
> case 54: op = rv_op_vfwsub_wf; break;
> case 56: op = rv_op_vfwmul_vf; break;
> + case 59: op = rv_op_vfwmaccbf16_vf; break;
> case 60: op = rv_op_vfwmacc_vf; break;
> case 61: op = rv_op_vfwnmacc_vf; break;
> case 62: op = rv_op_vfwmsac_vf; break;
> --
> 2.25.1
>
>
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 6/6] target/riscv: Add disas support for BF16 extensions,
Alistair Francis <=