[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/5] hw/riscv: Use misa_mxl instead of misa_mxl_max
From: |
Alistair Francis |
Subject: |
Re: [PATCH v6 1/5] hw/riscv: Use misa_mxl instead of misa_mxl_max |
Date: |
Thu, 23 Nov 2023 13:04:35 +1000 |
On Mon, Oct 30, 2023 at 3:50 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> The effective MXL value matters when booting.
This doesn't sound right. Surely the max is what matters here
Also, this was specifically changed to misa_mxl_max in db23e5d981a
"target/riscv: Replace riscv_cpu_is_32bit with riscv_cpu_mxl".
This needs a much better description of why this change should be made
Alistair
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> hw/riscv/boot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
> index 52bf8e67de..dad3f6e7b1 100644
> --- a/hw/riscv/boot.c
> +++ b/hw/riscv/boot.c
> @@ -36,7 +36,7 @@
>
> bool riscv_is_32bit(RISCVHartArrayState *harts)
> {
> - return harts->harts[0].env.misa_mxl_max == MXL_RV32;
> + return harts->harts[0].env.misa_mxl == MXL_RV32;
> }
>
> /*
> --
> 2.42.0
>
>
- Re: [PATCH v6 1/5] hw/riscv: Use misa_mxl instead of misa_mxl_max,
Alistair Francis <=