Re: [PATCH 02/19] tests: smbios: add test for -smbios type=11 option

[Ani Sinha]

> On 27-Feb-2024, at 21:17, Igor Mammedov <imammedo@redhat.com> wrote:
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

Empty description is not nice. Other than that,

Reviewed-by: Ani Sinha <anisinha@redhat.com>

> ---
> tests/data/smbios/type11_blob  | Bin 0 -> 11 bytes
> tests/qtest/bios-tables-test.c |  17 +++++++++++++++++
> 2 files changed, 17 insertions(+)
> create mode 100644 tests/data/smbios/type11_blob
> 
> diff --git a/tests/data/smbios/type11_blob b/tests/data/smbios/type11_blob
> new file mode 100644
> index 
> 0000000000000000000000000000000000000000..1d8fea4b0c6f040a13ba99c3fad762538b795614
> GIT binary patch
> literal 11
> Scmd;PW!S(N;u;*nzyJUX)&c?m
> 
> literal 0
> HcmV?d00001
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index b2992bafa8..a116f88e1d 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -2091,6 +2091,21 @@ static void test_acpi_pc_smbios_options(void)
>     free_test_data(&data);
> }
> 
> +static void test_acpi_pc_smbios_blob(void)
> +{
> +    uint8_t req_type11[] = { 11 };
> +    test_data data = {
> +        .machine = MACHINE_PC,
> +        .variant = ".pc_smbios_blob",
> +        .required_struct_types = req_type11,
> +        .required_struct_types_len = ARRAY_SIZE(req_type11),
> +    };
> +
> +    test_smbios("-machine smbios-entry-point-type=32 "
> +                "-smbios file=tests/data/smbios/type11_blob", &data);
> +    free_test_data(&data);
> +}
> +
> static void test_oem_fields(test_data *data)
> {
>     int i;
> @@ -2244,6 +2259,8 @@ int main(int argc, char *argv[])
> #endif
>             qtest_add_func("acpi/piix4/smbios-options",
>                            test_acpi_pc_smbios_options);
> +            qtest_add_func("acpi/piix4/smbios-blob",
> +                           test_acpi_pc_smbios_blob);
>         }
>         if (qtest_has_machine(MACHINE_Q35)) {
>             qtest_add_func("acpi/q35", test_acpi_q35_tcg);
> -- 
> 2.39.3
>