[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/24] exec: Declare CPUBreakpoint/CPUWatchpoint type in 'bre
|
From: |
Anton Johansson |
|
Subject: |
Re: [PATCH 02/24] exec: Declare CPUBreakpoint/CPUWatchpoint type in 'breakpoint.h' header |
|
Date: |
Thu, 25 Apr 2024 08:29:40 +0200 |
On 18/04/24, Philippe Mathieu-Daudé wrote:
> On 18/4/24 21:25, Philippe Mathieu-Daudé wrote:
> > The CPUBreakpoint and CPUWatchpoint structures are declared
> > in "hw/core/cpu.h", which contains declarations related to
> > CPUState and CPUClass. Some source files only require the
> > BP/WP definitions and don't need to pull in all CPU* API.
> > In order to simplify, create a new "exec/breakpoint.h" header.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> > include/exec/breakpoint.h | 23 +++++++++++++++++++++++
> > include/hw/core/cpu.h | 16 +---------------
> > target/arm/internals.h | 1 +
> > target/ppc/internal.h | 1 +
> > target/riscv/debug.h | 2 ++
> > 5 files changed, 28 insertions(+), 15 deletions(-)
> > create mode 100644 include/exec/breakpoint.h
Reviewed-by: Anton Johansson <anjo@rev.ng>
- [PATCH 00/24] include/exec: Rework (part 2), Philippe Mathieu-Daudé, 2024/04/18
- [PATCH 01/24] exec: Declare MMUAccessType type in 'mmu-access-type.h' header, Philippe Mathieu-Daudé, 2024/04/18
- [PATCH 02/24] exec: Declare CPUBreakpoint/CPUWatchpoint type in 'breakpoint.h' header, Philippe Mathieu-Daudé, 2024/04/18
- [PATCH 03/24] hw/core: Avoid including the full 'hw/core/cpu.h' in 'tcg-cpu-ops.h', Philippe Mathieu-Daudé, 2024/04/18
- [PATCH 04/24] exec: Restrict TCG specific declarations of 'cputlb.h', Philippe Mathieu-Daudé, 2024/04/18
- [PATCH 05/24] exec: Restrict 'cpu_ldst.h' to TCG accelerator, Philippe Mathieu-Daudé, 2024/04/18
- [PATCH 09/24] physmem: Restrict TCG CPU IOTLB code to TCG accel, Philippe Mathieu-Daudé, 2024/04/18
- [PATCH 06/24] exec: Have guest_addr_valid() methods take abi_ptr/size_t arguments, Philippe Mathieu-Daudé, 2024/04/18