Re: [PATCH v1 1/1] hw/riscv/boot.c: Support 64-bit address for initrd

[Alistair Francis]

On Mon, Apr 1, 2024 at 10:44 PM Cheng Yang <yangcheng.work@foxmail.com> wrote:
>
> Use qemu_fdt_setprop_u64() instead of qemu_fdt_setprop_cell()
> to set the address of initrd in FDT to support 64-bit address.
>
> Signed-off-by: Cheng Yang <yangcheng.work@foxmail.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  hw/riscv/boot.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
> index 09878e722c..47281ca853 100644
> --- a/hw/riscv/boot.c
> +++ b/hw/riscv/boot.c
> @@ -209,8 +209,8 @@ static void riscv_load_initrd(MachineState *machine, 
> uint64_t kernel_entry)
>      /* Some RISC-V machines (e.g. opentitan) don't have a fdt. */
>      if (fdt) {
>          end = start + size;
> -        qemu_fdt_setprop_cell(fdt, "/chosen", "linux,initrd-start", start);
> -        qemu_fdt_setprop_cell(fdt, "/chosen", "linux,initrd-end", end);
> +        qemu_fdt_setprop_u64(fdt, "/chosen", "linux,initrd-start", start);
> +        qemu_fdt_setprop_u64(fdt, "/chosen", "linux,initrd-end", end);
>      }
>  }
>
> --
> 2.34.1
>
>