|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH for-9.2 06/10] hw/remote/message.c: Don't directly invoke DeviceClass:reset |
Date: | Wed, 14 Aug 2024 15:48:52 +0200 |
User-agent: | Mozilla Thunderbird |
On 13/8/24 18:52, Peter Maydell wrote:
Directly invoking the DeviceClass::reset method is a bad idea, because if the device is using three-phase reset then it relies on transitional reset machinery which is likely to disappear at some point.
This seems like fix-for-9.1 material.
Reset the device in the standard way, by calling device_cold_reset(). Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/remote/message.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[Prev in Thread] | Current Thread | [Next in Thread] |