qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-9.2 00/10] s390: Convert virtio-ccw, cpu to three-phase r


From: Thomas Huth
Subject: Re: [PATCH for-9.2 00/10] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup
Date: Fri, 30 Aug 2024 14:21:33 +0200
User-agent: Mozilla Thunderbird

On 30/08/2024 14.17, Peter Maydell wrote:
On Fri, 30 Aug 2024 at 13:04, Peter Maydell <peter.maydell@linaro.org> wrote:

On Fri, 30 Aug 2024 at 12:56, Nico Boehr <nrb@linux.ibm.com> wrote:

Quoting Peter Maydell (2024-08-30 12:01:47)
I ran overnight with none of the patchset applied, and it never
failed (as expected). Running with just the first virtio-ccw
patch does fall over fairly quickly. So something's up with
that patch, which is curious because that's the one I thought
was a straightforward conversion without any complications :-)

I'll investigate further today, I have the beginnings of a
theory about what might be happening...

Thanks for taking the time, Peter! Let me know when you have insights.

I think I've found the problem, I'm just testing it to see if it
does properly fix the intermittent.

The fix is to add an extra patch at the start of the
series. Once I've tested this I'll send out a v2 of the series,
maybe also adding the cleanup RTH suggested in one of the later
patches.

By the way, how would you like this series to go upstream?
I can think of three options:
  * you take the whole thing through the s390 tree
  * I take the whole thing through my tree
  * you take the s390 specific patches, and I take the
    remaining reset-cleanup patches once those have landed

Any preference?

I'm fine if you take the patches through your tree along with the other reset-related patches.

 Thomas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]