Re: [PULL 86/89] target/riscv: Restore the predicate() NULL check behavior

[Michael Tokarev]

08.05.2023 01:21, Alistair Francis wrote:
> On Fri, May 5, 2023 at 11:08 AM Alistair Francis <alistair23@gmail.com> wrote:
> > From: Bin Meng <bmeng@tinylab.org>
> >
> > When reading a non-existent CSR QEMU should raise illegal instruction
> > exception, but currently it just exits due to the g_assert() check.
> >
> > This actually reverts commit 0ee342256af9205e7388efdf193a6d8f1ba1a617.
> > Some comments are also added to indicate that predicate() must be
> > provided for an implemented CSR.
> >
> > Reported-by: Fei Wu <fei2.wu@intel.com>
> > Signed-off-by: Bin Meng <bmeng@tinylab.org>
> > Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> > Reviewed-by: Weiwei Li <liweiwei@iscas.ac.cn>
> > Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> > Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
> > Message-Id: <20230417043054.3125614-1-bmeng@tinylab.org>
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
>
> Sorry, I didn't realise I should have done this with the PR, but this
> is a good candidate for going into 8.0.1

Queued for 8.0, with minor context tweak. Thank you!

/mjt