[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Revert "hw/sparc64/niagara: Use blk_name() instead of open-c
From: |
Markus Armbruster |
Subject: |
Re: [PATCH] Revert "hw/sparc64/niagara: Use blk_name() instead of open-coding it" |
Date: |
Tue, 16 May 2023 10:04:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> writes:
> On 15/05/2023 16:11, Markus Armbruster wrote:
>
>> This reverts commit 1881f336a33a8a99cb17ab1c57ed953682e8e107.
>> This commit breaks "-drive if=pflash,readonly=on,file=image.iso". It
>> claims to merely replace an open-coded version of blk_name() by a
>> call, but that's not the case. Sorry for the inconvenience!
>
> Ah so was this a case of replacing something that shouldn't have been
> replaced in the first place, or does it require a follow-up patch?
I was looking at inclusions of block/block_int*.h outside the block
subsystem, and went "Oh, I can get rid of this one!" Nope, brain
malfunction.
Reducing such inclusions is always nice, but the code this patch
restores isn't broken, and no follow-up fix is required.
>> Reported-by: Jakub Jermář <jakub@jermar.eu>
>> Cc: qemu-stable@nongnu.org
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
[...]
> Regardless of the above:
>
> Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Thanks!