[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] configure: unset harmful environment variables
From: |
Juan Quintela |
Subject: |
Re: [PATCH] configure: unset harmful environment variables |
Date: |
Thu, 25 May 2023 20:51:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Apart from CLICOLOR_FORCE and GREP_OPTIONS, there are other variables
> that are listed in the Autoconf manual. While Autoconf neutralizes them
> very early, and assumes it does not (yet) run in a shell that has "unset",
> QEMU assumes that the user invoked configure under a POSIX shell, and
> therefore can simply use "unset" to clear them.
>
> CDPATH is particularly nasty because it messes up "cd ... && pwd".
It is weird that nobody noticed it. I have been using that CDPATH since
last century. Yeap, that makes me definitely old.
> Reported-by: Juan Quintela <quintela@redhat.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Tested-by: Juan Quintela <quintela@redhat.com>
Thanks very much.