Re: [PATCH 06/12] target/s390x: Fix LRA when DAT is off

[David Hildenbrand]

On 03.07.23 17:50, Ilya Leoshkevich wrote:
> LRA should perform DAT regardless of whether it's on or off.
> Disable DAT check for MMU_S390_LRA.
>
> Fixes: defb0e3157af ("s390x: Implement opcode helpers")
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>   target/s390x/mmu_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
> index b04b57c2356..fbb2f1b4d48 100644
> --- a/target/s390x/mmu_helper.c
> +++ b/target/s390x/mmu_helper.c
> @@ -417,7 +417,7 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, 
> int rw, uint64_t asc,
>   
>       vaddr &= TARGET_PAGE_MASK;
>   
> -    if (!(env->psw.mask & PSW_MASK_DAT)) {
> +    if (rw != MMU_S390_LRA && !(env->psw.mask & PSW_MASK_DAT)) {
>           *raddr = vaddr;
>           goto nodat;
>       }

Interesting

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Cheers,

David / dhildenb