qemu-stable
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] virtio: Drop out of coroutine context in virtio_load()


From: Michael Tokarev
Subject: Re: [PATCH 2/2] virtio: Drop out of coroutine context in virtio_load()
Date: Tue, 17 Oct 2023 08:19:48 +0300
User-agent: Mozilla Thunderbird

05.09.2023 17:50, Kevin Wolf wrote:
virtio_load() as a whole should run in coroutine context because it
reads from the migration stream and we don't want this to block.

However, it calls virtio_set_features_nocheck() and devices don't
expect their .set_features callback to run in a coroutine and therefore
call functions that may not be called in coroutine context. To fix this,
drop out of coroutine context for calling virtio_set_features_nocheck().
...
Cc: qemu-stable@nongnu.org
Buglink: https://issues.redhat.com/browse/RHEL-832
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

It looks like this change caused an interesting regression,
  https://gitlab.com/qemu-project/qemu/-/issues/1933
at least in -stable.  Can you take a look please?

BTW, Kevin, do you have account @gitlab?

Thanks,

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]