qemu-stable
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] hw/net/can/sja1000: fix bug for single acceptance filter


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2] hw/net/can/sja1000: fix bug for single acceptance filter and standard frame
Date: Fri, 5 Jan 2024 22:58:25 +0100
User-agent: Mozilla Thunderbird

On 4/1/24 00:14, Pavel Pisa wrote:
From: Pavel Pisa <pisa@cmp.felk.cvut.cz>

A CAN sja1000 standard frame filter mask has been computed and applied
incorrectly for standard frames when single Acceptance Filter Mode
(MOD_AFM = 1) has been selected. The problem has not been found
by Linux kernel testing because it uses dual filter mode (MOD_AFM = 0)
and leaves falters fully open.

The problem has been noticed by Grant Ramsay when testing with Zephyr
RTOS which uses single filter mode.

Signed-off-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Reported-by: Grant Ramsay <gramsay@enphaseenergy.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2028
Fixes: 733210e754 ("hw/net/can: SJA1000 chip register level emulation")
---
  hw/net/can/can_sja1000.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Patch merged as commit 25145a7d77.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]