Re: [PATCH] vfio/pci: Clear MSI-X IRQ index always

[Cédric Le Goater]

On 1/25/24 15:42, Cédric Le Goater wrote:
> When doing device assignment of a physical device, MSI-X can be
> enabled with no vectors enabled and this sets the IRQ index to
> VFIO_PCI_MSIX_IRQ_INDEX. However, when MSI-X is disabled, the IRQ
> index is left untouched if no vectors are in use. Then, when INTx
> is enabled, the IRQ index value is considered incompatible (set to
> MSI-X) and VFIO_DEVICE_SET_IRQS fails. QEMU complains with :
>
> qemu-system-x86_64: vfio 0000:08:00.0: Failed to set up TRIGGER eventfd 
> signaling for interrupt INTX-0: VFIO_DEVICE_SET_IRQS failure: Invalid argument
>
> To avoid that, unconditionaly clear the IRQ index when MSI-X is
> disabled.


Applied to vfio-next.

Thanks,

C.