Re: [PATCH] tcg: Increase width of temp_subindex

[Philippe Mathieu-Daudé]

On 13/2/24 03:21, Richard Henderson wrote:
> We need values 0-3 for TCG_TYPE_I128 on 32-bit hosts.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 43eef72f4109 ("tcg: Add temp allocation for TCGv_i128")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2159
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>
> I feel certain that I made this change back when I introduced TCGv_i128.
> I imagine that something went wrong with a rebase and it got lost.
> Worse, we don't use temp_subindex often, and we usually handle i128
> this value correctly.  It took a quirk of register allocation ordering
> to make an invalid value in temp_subindex lead to a crash.
>
> ---
>   include/tcg/tcg.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>