Re: [PATCH] .gitlab-ci.d/windows.yml: Drop msys2-32bit job

[Peter Maydell]

On Tue, 20 Feb 2024 at 17:01, Thomas Huth <thuth@redhat.com> wrote:
>
> On 20/02/2024 17.56, Peter Maydell wrote:
> > MSYS2 is dropping support for 32-bit Windows.  This shows up for us
> > as various packages we were using in our CI job no longer being
> > available to install, which causes the job to fail.  In commit
> > 8e31b744fdf we dropped the dependency on libusb and spice, but the
> > dtc package has also now been removed.
> >
> > For us as QEMU upstream, "32 bit x86 hosts for system emulation" have
> > already been deprecated as of QEMU 8.0, so we are ready to drop them
> > anyway.
> >
> > Drop the msys2-32bit CI job, as the first step in doing this.
> >
> > This is cc'd to stable, because this job will also be broken for CI
> > on the stable branches.  We can't drop 32-bit support entirely there,
> > but we will still be covering at least compilation for 32-bit Windows
> > via the cross-win32-system job.
> >
> > Cc: qemu-stable@nongnu.org
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > Minimal patch that disables CI, for ease of backporting.
> > ---
> >   .gitlab-ci.d/windows.yml | 9 ---------
> >   1 file changed, 9 deletions(-)
> >
> > diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
> > index 5c1e385dc89..8fc08218d28 100644
> > --- a/.gitlab-ci.d/windows.yml
> > +++ b/.gitlab-ci.d/windows.yml
> > @@ -131,12 +131,3 @@ msys2-64bit:
> >       # qTests don't run successfully with "--without-default-devices",
> >       # so let's exclude the qtests from CI for now.
> >       TEST_ARGS: --no-suite qtest
> > -
> > -msys2-32bit:
> > -  extends: .shared_msys2_builder
> > -  variables:
> > -    MINGW_TARGET: mingw-w64-i686
> > -    MSYSTEM: MINGW32
> > -    EXTRA_PACKAGES:
> > -    CONFIGURE_ARGS:  --target-list=ppc64-softmmu -Ddebug=false 
> > -Doptimization=0
> > -    TEST_ARGS: --no-suite qtest
>
> We could maybe merge .shared_msys2_builder with the msys2-64bit job now that
> we only have one Windows-based job left ... but that's maybe also rather
> something for another patch

Yeah, that was the bit I left for a different patch for backporting
reasons. I'm also working on eg having the docs say 32-bit Windows
isn't supported, etc.

-- PMM