qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/7] QOM'ify PIIX southbridge creation


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 0/7] QOM'ify PIIX southbridge creation
Date: Mon, 30 May 2022 21:45:26 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1

On 30/5/22 21:11, Mark Cave-Ayland wrote:
On 29/05/2022 14:02, Bernhard Beschow wrote:

    Oh wait - I see now it's just the cover letter which is missing the additional     maintainer addresses :)  If you could add them into the cover letter for your next     revision that would be great, since it gives context for maintainers to help with
    the
    review process.


Hi Mark,

Thanks for your great work you put into reviews and the useful insights! It seems to me that the time it takes for patches to be queued depends on the subsystem - some are faster, some are slower...

I've automated my setup as described in [1]. However, it doesn't seem to work for the cover letter which I'd expect to be sent to the union of all reviewers of all patches. Any idea how to fix this?

Best regards,
Bernhard

[1] https://www.qemu.org/docs/master/devel/submitting-a-patch.html#cc-the-relevant-maintainer <https://www.qemu.org/docs/master/devel/submitting-a-patch.html#cc-the-relevant-maintainer>


Good question. I tend to do "git format-patch -o /tmp/foo --cover-letter" to generate the series, fill in the cover letter, and then use "git send-email /tmp/foo" to send out the emails (entering in the results of get_maintainer.pl by hand). I'm not sure why the cover letter isn't being generated correctly in your case I'm afraid.

Or try git-publish :) It does a first pass collecting Cc for each patch
(calling get_maintainer.pl) then use that set on the cover.

https://github.com/stefanha/git-publish



reply via email to

[Prev in Thread] Current Thread [Next in Thread]