[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/usb/hcd-ehci.c: print diagnostics when cpage out of range
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH] hw/usb/hcd-ehci.c: print diagnostics when cpage out of range |
Date: |
Thu, 9 Jun 2022 12:09:55 +0200 |
Hi,
> if (cpage > 4) {
> fprintf(stderr, "cpage out of range (%u)\n", cpage);
> + bytes = get_field(p->qtd.token, QTD_TOKEN_TBYTES);
> + offset = p->qtd.bufptr[0] & ~QTD_BUFPTR_MASK;
> + cpage = get_field(p->qtd.token, QTD_TOKEN_CPAGE);
> + fprintf(stderr, "reading %u bytes from offset %u at page %u\n",
> + bytes, offset, cpage);
I think we should either drop it (you've successfully debugged the
problem meanwhile, thanks for that), or turn it into a tracepoint.
Simply printing to stderr is deprecated.
take care,
Gerd
- Re: [PATCH] hw/usb/hcd-ehci.c: print diagnostics when cpage out of range,
Gerd Hoffmann <=