Re: [PATCH] hw: Remove unused fw_cfg_init_io

[Thomas Huth]

On 18/09/2024 14.35, dave@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>
> fw_cfg_init_io has been unused since
>    918a7f706b ("i386: load kernel on xen using DMA")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
>   hw/nvram/fw_cfg.c         | 5 -----
>   include/hw/nvram/fw_cfg.h | 1 -
>   2 files changed, 6 deletions(-)
>
> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
> index 2dadfd6e1f..b644577734 100644
> --- a/hw/nvram/fw_cfg.c
> +++ b/hw/nvram/fw_cfg.c
> @@ -1171,11 +1171,6 @@ FWCfgState *fw_cfg_init_io_dma(uint32_t iobase, uint32_t 
> dma_iobase,
>       return s;
>   }
>   
> -FWCfgState *fw_cfg_init_io(uint32_t iobase)
> -{
> -    return fw_cfg_init_io_dma(iobase, 0, NULL);
> -}
> -
>   FWCfgState *fw_cfg_init_mem_wide(hwaddr ctl_addr,
>                                    hwaddr data_addr, uint32_t data_width,
>                                    hwaddr dma_addr, AddressSpace *dma_as)
> diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h
> index d173998803..fa42677619 100644
> --- a/include/hw/nvram/fw_cfg.h
> +++ b/include/hw/nvram/fw_cfg.h
> @@ -321,7 +321,6 @@ void fw_cfg_add_extra_pci_roots(PCIBus *bus, FWCfgState *s);
>   
>   FWCfgState *fw_cfg_init_io_dma(uint32_t iobase, uint32_t dma_iobase,
>                                   AddressSpace *dma_as);
> -FWCfgState *fw_cfg_init_io(uint32_t iobase);
>   FWCfgState *fw_cfg_init_mem(hwaddr ctl_addr, hwaddr data_addr);
>   FWCfgState *fw_cfg_init_mem_wide(hwaddr ctl_addr,
>                                    hwaddr data_addr, uint32_t data_width,

Reviewed-by: Thomas Huth <thuth@redhat.com>