[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: tests: test -i/--inplace with backup suffix option
From: |
Jim Meyering |
Subject: |
Re: tests: test -i/--inplace with backup suffix option |
Date: |
Wed, 1 Jun 2016 08:14:58 -0700 |
On Tue, May 31, 2016 at 10:26 PM, Assaf Gordon <address@hidden> wrote:
> Hello,
>
>> Instead, I propose the attached patch (intended to be applied before
>> your test additions), that adds the envvar-check file, as used in grep
>> and coreutils, along with Makefile.am adjustments
>
> Attached improved (and expanded) tests, adjusted to the envvar-check patch
> (included as well).
>
> Unrelated to these, I think there might be an issue with
> 'testsuite/invalid-mb-seq-UMR.sh' - it uses 'LOCALE_JA' variable, but the
> variable is not passed using 'testsuite/Makefile.am' in 'TEST_ENVIRONMENT'
> like other locales.
> Perhaps something like:
> LOCALE_JA='$(LOCALE_JA)'
> would solve it. will investigate later on.
Well caught.
That actually fixes the failure of that test on many systems (at least
Centos6 and Centos7-based, but not on F24).
I will amend. Thank you!
- Re: tests: test -i/--inplace with backup suffix option, Assaf Gordon, 2016/06/01
- Re: tests: test -i/--inplace with backup suffix option,
Jim Meyering <=
- Re: tests: test -i/--inplace with backup suffix option, Jim Meyering, 2016/06/01
- Re: tests: test -i/--inplace with backup suffix option, Jim Meyering, 2016/06/01
- Re: tests: test -i/--inplace with backup suffix option, Assaf Gordon, 2016/06/02
- Re: tests, Assaf Gordon, 2016/06/03
- Re: tests, Jim Meyering, 2016/06/04
- Re: tests, Assaf Gordon, 2016/06/05
- Re: tests, Jim Meyering, 2016/06/06
- Re: tests, Jim Meyering, 2016/06/06