[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Fix most warnings with gcc 4.4 on Linux
From: |
Boris Dusek |
Subject: |
[PATCH] Fix most warnings with gcc 4.4 on Linux |
Date: |
Tue, 7 Sep 2010 18:13:44 +0200 |
On Sep 7, 2010, at 4:22 PM, Christopher Brannon wrote:
> Boris Du?ek <boris.dusek at gmail.com> writes:
>
>> src/c/api/libspeechd.c:263: warning: assignment discards qualifiers from
>> pointer target type
>> - I don't feel like I am able to correctly solve this one in little time
>
> Hello Boris,
> inet_ntop returns const char *, but its return value is placed in a
> variable of type char *.
> We should also be checking the return values of malloc and inet_ntop in
> this function.
> I'll send along a patch, though I don't have time to test it right now.
Hello Chris, thanks. I can't test the patch either, but if it is OK,
then there will be 0 warnings in Speech Dispatcher (along with the
2 patches I submitted before) on Linux amd64 with gcc 4.4. That would
be the time to celebrate by turning on -Werror :-)
[PATCH] Fix most warnings with gcc 4.4 on Linux, Christopher Brannon, 2010/09/07