[PATCH] Fix most warnings with gcc 4.4 on Linux

[Christopher Brannon]

Boris Du?ek <boris.dusek at gmail.com> writes:

> Hello,
>
> when building the Ubuntu package for 0.7.1 Beta 2, I noticed lot of warnings 
> in
> the build log from the PPA build server. Since having warnings is not good, I
> decided to fix them. I am posting a patch below that fixes most of them. Only 
> 2
> warnings remain on amd64 Ubuntu 10.04 with gcc 4.4.3:

Hello Boris,
This looks great!  I'll push it in a few hours, unless someone else
does so before then.  Here are my comments.

> diff --git a/src/server/options.h b/src/server/options.h
> index bcc10c4..c08a63e 100644
> --- a/src/server/options.h
> +++ b/src/server/options.h
> @@ -23,23 +23,9 @@
*SNIP*
> +const struct option *const spd_long_options;
>  
> -static char* spd_short_options = "dsal:c:S:p:P:C:vDh";
> +const char *const spd_short_options;

It isn't necessary to export these two variables, since they are only
referenced in options.c.

Also, I'm still seeing errors on i686 with -Wall.  These are different