|
From: | Andrei Kholodnyi |
Subject: | [PATCH] Various fixes for resolve_host, from src/c/api/libspeechd.c. |
Date: | Wed, 8 Sep 2010 23:06:16 +0200 |
Hi Chris, I think there is an error here. let's say resolved_ip = inet_ntop returns NULL. in this case resolve_buffer probably will be uninitialized or zeroed? and you jump after it in else }else{ *is_localhost = 0; - return ip = resolved_ip; + return ip = resolve_buffer; } in it you just return resolve_buffer. beside that you will never reach freeaddrinfo(addr_result);
[Prev in Thread] | Current Thread | [Next in Thread] |