[PATCH] rearrange code in intl sub directory

[William Hubbs]

Hi Andrei,

On Sun, Sep 12, 2010 at 09:33:08AM +0200, Andrei Kholodnyi wrote:
> Name of the patch does not correspond to what it is doing.
 
 The title of a commit message is supposed to be a one line summary of
 what the commit does, so I believe that the summary is fine since the
 patch does rearrange the code in the intl sub directory and the
 detailed portion of the commit message explains how this is being done.

> Patch itself is a way too big and shall be split into several patches.
> I see from your description there are at least 3 steps:
> - moves intl/ to src/common
> - turns that directory into a library of common routines
> - creates an include/ directory

Yes, there are several steps involved.  However, this is one logical
change, which I don't feel should be separated.  I'm not sure there is a
way to separate it and make it possible for each step to compile
cleanly.  That is why I wrote a very detailed commit message.

Imho every published commit should be a logical change which
compiles cleanly.

Thanks,

William
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100912/4d534d63/attachment.pgp>