[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] rearrange code in intl sub directory
From: |
Christopher Brannon |
Subject: |
[PATCH] rearrange code in intl sub directory |
Date: |
Sun, 12 Sep 2010 17:04:03 -0500 |
Andrei Kholodnyi <andrei.kholodnyi at gmail.com> writes:
> Why have you removed def.h? I'd like rather to keep it and rename to
> speechd_defaults.h
> This was a place to keep default values for speech dispatcher, there
> are tons of them flying around a source code.
> Now you have in two places the same define
> #define SPEECHD_DEFAULT_PORT 6560
>
> why you have moved str2intpriority(char* str) into config.c?
> - move some pieces of fdset.h to module_utils.h, not explained why
> - move some pieces of fdset.h to speechd.h, not explained why
Hi Andrei,
Please have a look at the following message from the archives:
http://lists.freebsoft.org/pipermail/speechd/2010q3/002331.html
These were Hynek's comments on the original patch.
-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100912/e405222c/attachment.pgp>