[PATCH] rearrange code in intl sub directory

[William Hubbs]

Hi Andrei and all,

I am reworking this, but I will supply comments below about what I'm
thinking.

On Mon, Sep 13, 2010 at 01:00:26AM +0200, Andrei Kholodnyi wrote:
> Thanks Chris.
> I do remember I have written it, but it was more than month ago.
> 
> > 1) TFDSetElement, TFDSetClientSpecific, SPDMsgSettings and
> > str2intpriority is specific to the server and should not be moved
> > to src/common/ but somewhere to src/server/.
> 
> Yes, I agree it makes sense to move str2intpriority to src/server

I want to rethink this again, because it is a conversion function, and
it could just as easily be left in the common library so it could be
used by the modules if they need to use it.

> SPDMsgSettings were moved to module_util.h now.
> I do not think it is correct, since it is used in server and modules.

Actually it is used in the modules only.

Do a "git grep SPDMsgSettings" and you will see it
in the modules and mentioned in the documentation.

> Pls. take a look into OTTS_MsgSettings
> We could probably move it back later on?
 
 I looked at it briefly, but I'm not sure what we were doing with it in
 the server of OpenTTS.  What I would say is, let's not worry about that
 until we need it.  If we decide we do, we can pull the typedef out of
 module_utils.h and put it in speechd_types.h.

> William,
> would it be possible to put more detailed description of the patch:
 
 I will send this back to the list once I have it reworked.  After
 getting away from it for a while, I can see that it may be able to be
 broken up into several patches.

William

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100913/cb0c9383/attachment.pgp>