[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 7/8] clean up Makefile for server directory
From: |
Christopher Brannon |
Subject: |
[PATCH 7/8] clean up Makefile for server directory |
Date: |
Sun, 19 Sep 2010 08:20:18 -0500 |
William Hubbs <w.d.hubbs at gmail.com> writes:
> - add a variable that points to the common library and use it in the
> speech_dispatcher_LDADD line.
> - remove definition of localedir since it is defined in configure.ac.
> - replace autoconf substitutions with make variables.
> - split AM_CFLAGS into speach_dispatcher_CFLAGS and
> speech_dispatcher_CPPFLAGS.
I'd suggest one more change to these Makefiles. Split long lines into
shorter pieces, using continuation characters. It will make it easier
to read and review subsequent patches which affect Makefiles.
Otherwise, it looks good.
-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100919/9744e63e/attachment.pgp>
- [PATCH 1/8] clean up Makefile for c api, William Hubbs, 2010/09/19
- [PATCH 2/8] clean up Makefile for audio directory, William Hubbs, 2010/09/19
- [PATCH 3/8] clean up the Makefile for spd-say, William Hubbs, 2010/09/19
- [PATCH 4/8] clean up the Makefile for spdsend, William Hubbs, 2010/09/19
- [PATCH 5/8] clean up the Makefile for the common source directory, William Hubbs, 2010/09/19
- [PATCH 6/8] clean up the Makefile for the modules directory, William Hubbs, 2010/09/19
- [PATCH 7/8] clean up Makefile for server directory, William Hubbs, 2010/09/19
- [PATCH 7/8] clean up Makefile for server directory,
Christopher Brannon <=
- [PATCH 8/8] clean up Makefile for tests directory, William Hubbs, 2010/09/19
- [PATCH 1/8] clean up Makefile for c api, Andrei Kholodnyi, 2010/09/19