reviewers modifying code they are reviewing

[Christopher Brannon]

Hynek Hanke <hanke at brailcom.org> writes:

> 1) Reviewer must not change the patch code himself,
> he must always first consult the author. Otherwise code
> is getting into the repository which was not reviewed by
> a second person.

Hello Hynek,
Exactly.  When someone modifies and pushes a patch, he's committing his
own code.

> 2) Trivial changes can be made by the reviewer, but only
> if they are corrections in formatting, obvious resolutions
*SNIP*

> If there are no objections, I'll make this text into a new
> chapter in the coordination guidelines document.

Wonderful!  It's nice to have all of this information written down
somewhere.

Regards,
-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100920/4e39f86e/attachment.pgp>