[PATCH] Add a portable implementation of getline to src/common.

[Christopher Brannon]

Hello Boris,

Boris Dusek <dusek at brailcom.org> writes:

> I would add a doc comment before the function to stress the difference between
> POSIX getline and this spd_getline - something like this:

Yes, this is a good idea.

> maybe better spelled as `null' (and without capitals, since
> it does not have anything to do with the pointer constant NULL).

I have no idea when or why I started using NUL to denote the 0 byte at
the end of a string.  I'll drop that convention.

> but did you check the other changes from getline to
> spd_getline for allocation consistency?

Yes.  We're using GLib for everything now, so allocation is consistent
with respect to spd_getline.

> Otherwise thanks for this patch, I was just thinking of doing the same as part
> of the Mac OS X port.

You're welcome.  Thanks for commenting on my patch!

-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100928/ce31f937/attachment.pgp>