[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Mark spsay messages for translation.
From: |
Rui Batista |
Subject: |
[PATCH] Mark spsay messages for translation. |
Date: |
Thu, 07 Oct 2010 15:53:05 +0100 |
Hi,
Qui, 2010-10-07 ?s 09:10 -0500, William Hubbs escreveu:
> I hesitate to push this patch, because I'm not sure we want spd-say to
> depend on libcommon. That library is for code that is shared between
> the server and modules, so I think the clients should do their own thing
> separately.
>
I understand your point of view and thought about this when
implementing... The thing is: if we needed a getline for clients for
instance, should we have also dupplicate code? We can copy the i18n_init
function for clients, but it is dupplication of code...
IMO, libcommon is *our* internal code. Other clients will not use
neither our i18n routines nor spd_getline. But considering we are
working in speech-dispatcher code base we can use a common library
for ..common code, even for clients. We might create a cmmon library for
clients but that would be kind of useless...
Anyway I understand your point but prefere this dependency over
dupplication of code.
This is my opinion, whatever people think it's better is good for me.
Rui Batista
William
>
- [PATCH] Mark spsay messages for translation., Rui Batista, 2010/10/07
- [PATCH] Mark spsay messages for translation., William Hubbs, 2010/10/07
- [PATCH] Mark spsay messages for translation., William Hubbs, 2010/10/07
- [PATCH] Mark spsay messages for translation.,
Rui Batista <=
- [PATCH] Mark spsay messages for translation., Andrei . Kholodnyi, 2010/10/14
- [PATCH] Mark spsay messages for translation., Rui Batista, 2010/10/14
- [PATCH] Mark spsay messages for translation., William Hubbs, 2010/10/15
- [PATCH] Mark spsay messages for translation., Andrei Kholodnyi, 2010/10/29
- [PATCH] Mark spsay messages for translation., William Hubbs, 2010/10/30