speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

tone generation patches


From: Christopher Brannon
Subject: tone generation patches
Date: Thu, 21 Oct 2010 17:16:28 -0500

Trevor Saunders <trev.saunders at gmail.com> writes:

> I took a quick look through your patch, and it looks fine to me.
> However I wonder why you want to deal with generating tones in each
> module?  It seems to me like we could just have do_tone() deal with
> generating the tone and playing it,  and not have to worry about it in
> each module.

The actual tone generation will be done in a helper function in
module_utils.c.  The module_speak function, which is defined once per
module, will need a case for MSGTYPE_TONE.
I probably wasn't clear about this in my comments.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101021/a99a00cd/attachment.pgp>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]