[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Guarantee that an output module is loaded at most once.
From: |
Christopher Brannon |
Subject: |
[PATCH] Guarantee that an output module is loaded at most once. |
Date: |
Wed, 16 Feb 2011 02:06:06 +0000 |
William Hubbs <w.d.hubbs at gmail.com> writes:
> Did indent(1) set this up with the return type on a line by itself?
Hi William,
Yes, it did.
> strcmp() isn't a boolean function, so I think it makes more sense to
> check for a specific return value instead of treating the return value
> like a boolean.
Maybe so. But !strcmp(...) is a pretty idiomatic way to test for string
equality. Change !strcmp(s1, s2) to strcmp(s1, s2) == 0 if you like.
Or I can resend, if you'd rather I do so.
-- Chris