speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] fix execlp processing


From: Boris Dušek
Subject: [PATCH] fix execlp processing
Date: Sat, 19 Mar 2011 14:24:47 +0100

Hello William,

On Mar 19, 2011, at 4:17 AM, William Hubbs wrote:

> If this function returns, it indicates a failure, so there is no need to
> test the return code.
> <snip>
> -             if (execlp("festival", "", (char *)0) == -1)
> -                     exit(1);
> +             execlp("festival", "", (char *)0);
> +             exit(1);

you and Trev are right that the if was not needed, I understood it wrongly
yesterday (it was late at night).

I just sent a new patch that uses both this patch and takes only single code
path for the exec* call.

Cheers,
Boris




reply via email to

[Prev in Thread] Current Thread [Next in Thread]