Re: tramp-dissect-file-name new user-error message

[Thierry Volpiatto]

Michael Albinus <address@hidden> writes:

> Nope. All such third party tools shall simply let-bind `non-essential' to t
> when doing file name completion (aka calling `file-name-all-completions').
> That's all.

Yes done.

>>> In helm, when you complete file names, you shall let-bind `non-essential'
>>> to t.
>>
>> Not exactly, I must bind it to t at beginning and let-bind it to nil
>> when needed in some places.
>> This is why I never been able to use it up to now.
>
> Again, `non-essential' is set globally to nil. This shall not be changed
> by any package.

Yes of course, read "let-bind to t at the beginning" instead of "bind to
t at the beginning", sorry.

> You only need to wrap around `file-name-all-completions' call.
I don't use this.

>> I will use this instead of defadvicing tramp-dissect-file-name.
>
> Ohh. You should never do this! I even recommend not to call
> `tramp-dissect-file-name'. Please use only Tramp functions which are
> documented in the manual.

I use `tramp-dissect-file-name' since some years now with no problems:
(this is now called with non-essential let-bound to t)

(defun helm-create-tramp-name (fname)
  "Build filename for `helm-pattern' like /su:: or /sudo::."
  (apply #'tramp-make-tramp-file-name
         (loop with v = (tramp-dissect-file-name fname)
               for i across v collect i)))

So what should I use instead ?

>> BTW I am not a ido user, so I can tell, but double check this error
>> message is not breaking ido in the same way it broke tramp completion in
>> helm.
>
> ido DTRT in `ido-file-name-all-completions-1':

Ok.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997