Re: Enable adb port in tramp adb

[Ashi]

Hi, Michael,
I've found the reason causes the tramp-test22-file-times failed.

I evaluate "(set-file-times "/adb:10.164.2.12#5555:data/local/tramp_testdir/tramp-test12242_Hq" '(0 1))", and it returns "t". But "(file-attributes "/adb:10.164.2.12#5555:data/local/tramp_testdir/tramp-test12242_Hq")" returns:
(nil 1 0 0
     (0 0)
     (-948638 13211)
     (0 0)
     3 "-rw-rw-rw-" t 1
     (-1 . 6))
which causes "(should (equal (nth 5 (file-attributes tmp-name1)) '(0 1)))" failed. And I've checked that "adb shell" has no perl(1) or stat(1). I think there is some problem in "set-file-times". What can we do in this test?

Best regards,
Zhongwei

On Sat, Oct 25, 2014 at 3:37 PM, Michael Albinus <address@hidden> wrote:

Ashi <address@hidden> writes:

> Hi, Michael,

Hi Zhongwei,

> My previous problem is solved by installing emacs24.4.1. Now it can
> run some of the tests, but it still fails on some cases. Here is the
> summary:
>
> Aborted: Ran 35 tests, 23 results as expected, 1 unexpected, 2 skipped
> (2014-10-24 17:26:08+0800)
>
> 1 unexpected results:
> FAILED tramp-test22-file-times

In every single test case you could activate `tramp--instrument-test-case'.
This will produce traces. Do it like this:

--8<---------------cut here---------------start------------->8---
*** /home/albinus/src/tramp/test/tramp-tests.el.~1~     2014-10-24 16:25:13.000000000 +0300
--- /home/albinus/src/tramp/test/tramp-tests.el 2014-10-24 16:39:30.000000000 +0300
***************
*** 1150,1155 ****
--- 1150,1156 ----
       (tramp-find-foreign-file-name-handler tramp-test-temporary-file-directory)
       '(tramp-gvfs-file-name-handler tramp-smb-file-name-handler))))

+   (tramp--instrument-test-case 10
    (let ((tmp-name1 (tramp--test-make-temp-name))
        (tmp-name2 (tramp--test-make-temp-name))
        (tmp-name3 (tramp--test-make-temp-name)))
***************
*** 1175,1181 ****
            (should-not (file-newer-than-file-p tmp-name3 tmp-name1))))
        (ignore-errors
        (delete-file tmp-name1)
!       (delete-file tmp-name2)))))

  (ert-deftest tramp-test23-visited-file-modtime ()
    "Check `set-visited-file-modtime' and `verify-visited-file-modtime'."
--- 1176,1182 ----
            (should-not (file-newer-than-file-p tmp-name3 tmp-name1))))
        (ignore-errors
        (delete-file tmp-name1)
!       (delete-file tmp-name2))))))

  (ert-deftest tramp-test23-visited-file-modtime ()
    "Check `set-visited-file-modtime' and `verify-visited-file-modtime'."
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.