adonthell-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Adonthell-devel] Cleanup and some changes


From: Kai Sterker
Subject: [Adonthell-devel] Cleanup and some changes
Date: Thu, 25 Mar 2010 19:06:23 +0100

Josh,

I modified the logging code you checked in a little. Hope you don't
mind! Basically, initialization is moved to adonthell::init_args, as
that way we get logging for Python scripts and C++ programs. E.g.

Tenebrae:~/adonthell/adonthell/test kai$ GLOG_logtostderr=1 python
eventtest.py -g .
I0325 18:51:41.195318 2684415368 adonthell.cc:148] Adonthell starting up!
I0325 18:51:41.198158 2684415368 adonthell.cc:149]   Invoked as:
python eventtest.py
I0325 18:51:41.199010 2684415368 adonthell.cc:152]     -g
I0325 18:51:41.199790 2684415368 adonthell.cc:152]     .

or

Tenebrae:~/adonthell/adonthell-build/test kai$ GLOG_logtostderr=1
.libs/worldtest -g ../../ wastesedge-git
I0325 18:45:02.992316 2684415368 adonthell.cc:148] Adonthell starting up!
I0325 18:45:03.046998 2684415368 adonthell.cc:149]   Invoked as: .libs/worldtest
I0325 18:45:03.047976 2684415368 adonthell.cc:152]     -g
I0325 18:45:03.048810 2684415368 adonthell.cc:152]     ../../
I0325 18:45:03.049571 2684415368 adonthell.cc:152]     wastesedge-git

Also removed the extra initialization in worldtest, as glog didn't
like that at all.


Btw., I think glog is pretty neat. So far I only added logging for
error cases, where the overhead didn't matter anyway. But with glog,
it's possible to add logging where it's useful during development
without ending up with a release that floods the user with useless
debug output :-).


Regarding the autoconf macros you checked in. I believe they should
not be kept in the repository for at least two reasons:
* They are products of ./autogen.sh, not "original" source files.
* When running 'make dist', they end up in the package, so for end
users that consume an official release, they will be part of the build
tree, as suggested by autoconf.

Kai

P.S.: Also changed the makefiles, in the hope that libtool will now
link to the libs it just built, not to the ones previously installed.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]