automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Parallel tests execution [0/4]


From: Akim Demaille
Subject: Re: Parallel tests execution [0/4]
Date: Thu, 16 Oct 2008 16:05:47 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.95 (gnu/linux)

>>> "RW" == Ralf Wildenhues <address@hidden> writes:

 > Hello everyone,

Hi Ralf,

I'm sorry for not being more responsive :(  And many, many thanks for
carrying this work to completion.

 > These four patches implement parallel execution of TESTS in Automake,
 > adapted from the check.mk file Akim Demaille posted earlier.

For the records, I attached the version I'm currently using.

Attachment: check.mk
Description: Binary data


 > 3) should work with different test naming styles:
 >      - *.test (with log files named s/\.test$/.log/)
 >      - no particular suffix (log files will be s/$/.log/)
 >      - should work with executables (e.g., TESTS = $(check_PROGRAMS))
 >      - arbitrary other suffixes

Yep.

 > 6) lazy test completion (do not rerun already-run tests),

This one must be optional, but it provides huge savings when it
applies.

 > - (5), (6), (8) are provided already by the check.mk code, except that
 >   (8) didn't work.

Actually I never meant to have hard error stop the whole test suite.
The point of hard-errors as they were defined in check.mk was to make
them *non* ignorable.  For instance our test suite raises a hard-error
if the program make a segmentation fault, which we never want to
tolerate.

 > - output `PASS: foo.test' not `PASS: foo.log'

This was actually a feature :) We use an Emacs mode that opens the
(log) file when we click on it.


 > - shouldn't test-suite.log also be created if all tests passed?

Why not, in which case it would be mostly empty and containing some
like "all the tests passed as expected"?

 > - should skipped tests show up in test-suite.log?

Can be useful, indeed.

 > - is everybody ok with the following authorship for patch 1/4?
 >   2008-10-XX  Akim Demaille <address@hidden>
 >               Jim Meyering <address@hidden>
 >               Benoit Sigoure <address@hidden>
 >               Ralf Wildenhues <address@hidden>

 >   (as git allows only one author, I will put the first name in --author)

Thanks :)  I think that some of the parts about tput were from Bob
Proulx, but I'm not sure.

 > - how should I best acknowledge The Vaucanson Group?  Something like
 > this in lib/am/check.am ok?

 > ## This code is adapted from check.mk which came from:
 > ##
 > ## Vaucanson, a generic library for finite state machines.
 > ## Copyright (C) 2006, 2007 The Vaucanson Group.

Actually it would be more fair to thanks EPITA and Gostai, both worked
on it, and Vaucanson was just the initial impetus to develop this.

 > The only reason I haven't put this in yet is that it would require a
 > copyright disclaimer from Vaucanson.  What do you think?

A mere thank, or whatever you feel is most appropriate will be
perfect.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]