Re: [PATCH 5/5] Improved test silent5.test.

[Stefano Lattarini]

At Sunday 25 April 2010, Ralf Wildenhues <address@hidden> 
wrote:
> * Stefano Lattarini wrote on Sun, Apr 25, 2010 at 05:13:11PM CEST:
> > At Sunday 25 April 2010, Ralf Wildenhues wrote:
> > > Indeed.  Grepping for '^mv ' and ' mv ' should work though.
> >
> > Or better again, we could strip off the `Entering/Leaving
> > directory' lines outputted by GNU make.  WDYT?
> 
> Other makes have the tendency to print other unrelated stuff.
OK, then I'll go for the simpler way.

> > OK, then I'll turn that `rm -f' into sanity checks with `test !
> > -f'.
> 
> Why?  This is tested for in another test, 
True.

> and you didn't seem to
>  think before that it would be broken at the end of the loop. 
Sorry, I don't understand what you are saying here.  Can you elaborate 
a bit more?
>  That's not logical.

OK, I'll simply remove the `rm -f' at the end of the loop then, since 
maintainer-check should remove those files anyway (and it's indeed very 
unlikely that the maintainer-check target will be broken by future 
changes).  I still have a little uneasy feeling about this, though
(could it be a hint of paranoia :-)

Anyway, I'll keep the `rm -f' in the middle of the loop (before
`make V=1'), as that's *required* to have a truly clean build.

Regards,
    Stefano