automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Minor improvements in bootstrap script.


From: Ralf Wildenhues
Subject: Re: [PATCH] Minor improvements in bootstrap script.
Date: Thu, 10 Jun 2010 19:39:44 +0200
User-agent: Mutt/1.5.20 (2009-10-28)

Hi Stefano,

* Stefano Lattarini wrote on Thu, Jun 10, 2010 at 03:15:39PM CEST:
> Well, after having read your considerations, I'm no more OK with the 
> patch myself; maybe I'll amend it later, to keep just the spacing and 
> comsetic changes, and adding a comment about the reason we can't 
> assume existence of /bin/sh.
> 
> But... I note that autoconf-generated configure scripts determine PATH 
> separator in (more or less)  the same way my pached bootstrap script 
> does:
[...]
> If we assume autoconf is correct, I think that it would be better to 
> just copy this code snippet in the bootstrap script.

Yes.  The changes are ok if you split the patch into one purely without
semantic changes, and the rest (so that we don't need to revert the
former when the latter turns out to be bad); and for setting the PATH
separator, please use the code from Autoconf.  Bonus points for
lower-casing the first words in error messages and prepending (pre-set)
`$me: '.  ;-)

Thanks,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]