[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHES] Minor cleanup and/or cosmetic patches for the testsuite.
From: |
Stefano Lattarini |
Subject: |
Re: [PATCHES] Minor cleanup and/or cosmetic patches for the testsuite. |
Date: |
Sat, 12 Jun 2010 20:35:56 +0200 |
User-agent: |
KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.4; i686; ; ) |
At Saturday 12 June 2010, Stefano Lattarini wrote:
> At Saturday 12 June 2010, Ralf Wildenhues wrote:
> > patch 4 is not, because it will do the wrong thing with, say,
> > AUTOUPDATE='autoupdate --verbose'.
>
> You're righ :-(
>
> substutite it with one adding a proper comment about why the `set'
> hack is required.
Done in the attached patch. OK to apply?
Regards,
Stefano
From 7e775d7ecf8c071c4f11b31fdad88a1f955cbb6e Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Sat, 12 Jun 2010 20:32:00 +0200
Subject: [PATCH] Add useful comment in test script obsolete.test.
* tests/obsolte.test: Add a comment explaining why we need
an indirection in adding $AUTOUPDATE to $required.
---
ChangeLog | 6 ++++++
tests/obsolete.test | 5 ++++-
2 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index c4e69a5..4e5071d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-06-12 Stefano Lattarini <address@hidden>
+
+ Add useful comment in test script obsolete.test.
+ * tests/obsolte.test: Add a comment explaining why we need
+ an indirection in adding $AUTOUPDATE to $required.
+
2010-06-12 Ralf Wildenhues <address@hidden>
Remove a couple of unneeded conditionals from tests.
diff --git a/tests/obsolete.test b/tests/obsolete.test
index e6601c9..337e4db 100755
--- a/tests/obsolete.test
+++ b/tests/obsolete.test
@@ -1,5 +1,6 @@
#! /bin/sh
-# Copyright (C) 1996, 2001, 2002, 2007, 2008 Free Software Foundation, Inc.
+# Copyright (C) 1996, 2001, 2002, 2007, 2008, 2010 Free Software
+# Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -16,6 +17,8 @@
# Test to make sure obsolete macros can be autoupdated.
+# We need the following indirection in case someone exported e.g.
+# AUTOUPDATE='autoupdate --verbose'.
set x ${AUTOUPDATE-autoupdate}
required=$2
. ./defs || Exit 1
--
1.6.5