[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] aclocal: remove @automake_includes

From: Paolo Bonzini
Subject: Re: [PATCH 2/3] aclocal: remove @automake_includes
Date: Sun, 14 Nov 2010 18:28:18 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101027 Fedora/3.1.6-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6

On 11/14/2010 05:46 PM, Ralf Wildenhues wrote:
Hi Paolo,

* Paolo Bonzini wrote on Tue, Nov 09, 2010 at 08:14:39PM CET:
This patch simplifies the overly complicated rules for ACLOCAL_PATH
vs. @automake_includes and @system_includes, by stating that
ACLOCAL_PATH will override even @automake_includes.  The simplest
way to achieve this is to remove @automake_includes altogether.

I've read the previous discussion about this now, but I'm still not sure
I understand the rationale for this change.  Is it because you want to
actually be able to override the $(datadir)/aclocal-$VERSION files with
this variable?  If so, why?

I don't really need to override the files, it's just to simplify the semantics and make ACLOCAL_PATH between -I and the system variables.

If the only reason is that --acdir doesn't accurately reflect what would
happen after 'make install', maybe we can instead fix --acdir?

That's not a problem, during the testsuite it is safer to operate as if $(datadir)/aclocal is empty, and --acdir achieves that. So I think --acdir is fine.

If you would prefer to fix --acdir, it would be in theory possible to make --acdir change @automake_includes and empty @system_includes instead.

However, before going on, I might be missing something. Google code search shows a relatively large amount of strange uses of --acdir, even in projects using relatively recent Autoconf (like 1.9.x). I'm not sure how they work; for example:

acdir = m4
@MAINT@ echo 'acfiles = \' > address@hidden
@MAINT@ find $(acdir) -type f -name '*.m4' -print               \
@MAINT@   | sed 's!^!$(top_srcdir)/!'                           \
@MAINT@   | tr '\012' ' '                                       \
@MAINT@   >> address@hidden
@MAINT@ echo >> address@hidden
@MAINT@ mv address@hidden $@

@address@hidden aclocal-files

@address@hidden Override default rule to use --acdir option
@address@hidden(srcdir)/aclocal.m4: $(acfiles)
@MAINT@ cd $(srcdir) && aclocal --acdir=$(acdir)

How can this work, wouldn't it miss all the internal Automake macros?

I'm not sure if you stated whether the testsuite passes for you with
this patch series.

Yes, it works.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]