automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [FYI] {maint} tests/README: update obsoleted advice


From: Stefano Lattarini
Subject: Re: [FYI] {maint} tests/README: update obsoleted advice
Date: Mon, 30 May 2011 23:54:10 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

On Sunday 22 May 2011, Stefano Lattarini wrote:
> On Sunday 22 May 2011, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Fri, May 20, 2011 at 10:21:09PM CEST:
> > > * tests/README (Section "Writing test cases" subsection "Do"):
> > > Do not suggest to use the `*-p.test' pattern for the names of
> > > hand-written tests which use the `parallel-tests' Automake option.
> > > Not only is this not respected by the existing tests, but it is
> > > more likely to cause conflicts with auto-generated tests.
> > > So, suggest to *avoid* using the `*-p.test' pattern in names
> > > of hand-written tests instead.
> > > (Section "Writing test cases" subsection "Do not"):  When
> > > suggesting not to override Makefile variables using command
> > > line arguments, do not use the badly outdated variables `U'
> > > and 'ANSI2KNR' in the example; instead, use the more common
> > > and typical `DESTDIR'.
> > 
> > Actually, this change has a slight technical error: when some variable
> > is never initialized in the Makefile, -e is not necessary in order to
> > override it.  DESTDIR is such a variable: we ensure that we do not ever
> > initialize it.  And as such, it is quite portable to use
> >   make DESTDIR=/foo/bar install
> > 
> > and in fact, quite widely used.
> >
> You're perfectly right.
> 
> > Can we use some other variable as example?  How about prefix?
> >
> Seems good.  I've prepared the attached patch (in your name, with me as
> co-author in ChangeLog).  I'll wait for your ACK before pushing.
> 
> Sorry for the noise,
>   Stefano
> 
I've pushed the patch now; I hope you're ok with it.

Regards,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]