[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] depcomp tests: speed up libtool-based tests

From: Stefano Lattarini
Subject: Re: [PATCH] depcomp tests: speed up libtool-based tests
Date: Thu, 09 Feb 2012 14:08:42 +0100

On 02/09/2012 12:05 PM, Peter Rosin wrote:
> Stefano Lattarini skrev 2012-02-09 11:36:
>> Sorry to answer to myself, but I think I've found a better, simpler
>> and more appropriate way to speed up the depcomp+libtool tests.  See
>> attached patch.
>> OK for master?
> I was wondering about the multiple libtool runs, but figured there
> was some difference if you only built shared or only built static,
> compared to doing both in the same build.  But that does not seem to
> be the case if I read the rationale for this change.
Well, duh!  By re-reading the diffs of commit e89ec38d (which is my only
reference in this matter), it seems that your objection is correct and my
rationale is wrong, in that the bug fixed by that commit presented itself
only when the building of shared libraries was somehow disabled.  So we
still need to go with something similar to the first patch -- but, unless
I'm again mistaken, we need do the extra checks only for the depmodes for
which the location of the compiler-generated depfiles can depend on which
flavour of libraries are being built by libtool.  Attached is a patch that
attempts to do so.  Since my brain clearly isn't functioning properly in
this matter, I will wait for an ACK before pushing.


Attachment: 0001-depcomp-tests-avoid-redundant-runs-for-libtool-tests.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]