Re: [Axiom-developer] Re: sock_get_string_buf

[Gabriel Dos Reis]

Waldek Hebisch <address@hidden> writes:

| > Greetings, and thanks so much!
| > 
| > Waldek Hebisch <address@hidden> writes:
| > 
| > > I again had problem with "sock_get_string_buf": trying to use hypertex
| > > functions which require Axiom (for example search or tutorial input)
| > > gives:
| > > 
| > > (1) ->
| > >    >> System error:
| > >    Unexpected end of #<string-input stream from "                ...">.
| > > 
| > > Recent patch to gcl fixed the problem on many machines. But on one
| > > machine (using 2.4.31 kerenel) I was still getting this error.
| > > 
| > > So I tried the patch below and it solved the problem.  AFAICS the
| > > problem is that GCL string parameter wants to preserve string
| > > _value_, but what Axiom want is pass by reference.  My undersanding
| > > is that GCL has full right to copy the string, so the only relaiable
| > > solution must use 'object' type and extract string address from it.
| > > 
| > > Remark1: It seems that "official" GCL foreign function interface is
| > > is very incomplete for real world needs. I would suggest either
| > > promoting 'object' structure as documented, official low level
| > > interface, or adding few more arguments types (mostly arrays by 
reference).
| > > 
| > > Remark 2: This may be related to Debian bug 328480 (but what Camm
| > > wrote seem indicate different problem).
| > > 
| > 
| > This indeed fixes the above -- thanks!  Some axiom code must be
| > declining do write to a copied buffer or some such.
| > 
| > May I suggest adding
| > 
| >           "   if (x->st.st_fillp<j) FEerror(\"string too small\",0);"
| >
| 
| Yes, good idea.


Great!

I would like to see the final patch, e.g. the things that would be
committed, including the explanation of what the code and what is
going in the pamphletss.

-- Gaby