bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Miscellaneous code readability improvements.


From: Joel E. Denny
Subject: Re: [PATCH] Miscellaneous code readability improvements.
Date: Tue, 18 Aug 2009 00:14:39 -0400 (EDT)
User-agent: Alpine 1.00 (DEB 882 2007-12-20)

On Fri, 14 Aug 2009, Akim Demaille wrote:

> (the inconsistency on the colon looks like an error to me, it's been a long
> time since I last filed a bug report about gcc ;).
> 
> Maybe we need to get rid of the backslash from the culprit part:
> 
>       invalid character for \-escape: `z'
>       invalid character for \-escape: `\n'
> 
> ?

Ah, I like that approach.

Also, as you mentioned earlier, I think we could drop the quotes.  We'd 
just have to request that quotearg convert spaces into escape sequences.

However, when requesting a special quoting style from quotearg, AFAICT, 
both the quoting style definition and the quoted string require memory 
allocation that isn't required otherwise.  That'll make scan-gram.l a 
little more complicated than the simple invocations we have now.  I also 
want to fix this limitation for some of my offline work that uses 
quotearg, so I may work on a gnulib patch before returning to this issue.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]