[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Miscellaneous code readability improvements.
From: |
Eric Blake |
Subject: |
Re: [PATCH] Miscellaneous code readability improvements. |
Date: |
Thu, 27 Aug 2009 20:52:15 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Joel E. Denny on 8/27/2009 3:37 PM:
>>>> * src/scan-gram.l (splice): Avoid compiler warning.
>>> I would say the correct top-level construct is
>>> <SC_ESCAPED_STRING,SC_ESCAPED_CHARACTER> rather than splice. git doesn't
>>> know how to read Flex specifications.
>> OK; I'll adjust that before pushing.
>
> Please push. Thanks.
Pushed on all three branches. But I'm still seeing some other warnings,
which, when coupled with ./configure --enable-gcc-warnings, are stopping
the build (no patch at this time); I had to use 'make WERROR_FLAGS=' to go on:
branch-2.4.2
In file included from scan-code-c.c:3:
scan-code.c:714: warning: declaration of 'debug_flag' shadows a global
declaration
getargs.h:38: warning: shadowed declaration is here
branch-2.5
In file included from symtab.h:31,
from gram.h:106,
from InadequacyList.h:24,
from AnnotationList.h:25,
from AnnotationList.c:23:
scan-code.h:137: warning: declaration of 'named_ref' shadows a global
declaration
named-ref.h:35: warning: shadowed declaration is here
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqXRl8ACgkQ84KuGfSFAYD92gCfQ9SDrCLNyug62i6HyUp6GgMM
nNQAoITv/HrlJOuIqPGABh2ybEPZStDN
=W/6X
-----END PGP SIGNATURE-----
- Re: [PATCH] Miscellaneous code readability improvements., (continued)
- Re: [PATCH] Miscellaneous code readability improvements., Akim Demaille, 2009/08/14
- Re: [PATCH] Miscellaneous code readability improvements., Joel E. Denny, 2009/08/18
- Re: [PATCH] Miscellaneous code readability improvements., Joel E. Denny, 2009/08/19
- Re: [PATCH] Miscellaneous code readability improvements., Akim Demaille, 2009/08/19
- Re: [PATCH] Miscellaneous code readability improvements., Joel E. Denny, 2009/08/19
- Re: [PATCH] Miscellaneous code readability improvements., Joel E. Denny, 2009/08/21
- Re: [PATCH] Miscellaneous code readability improvements., Eric Blake, 2009/08/27
- Re: [PATCH] Miscellaneous code readability improvements., Joel E. Denny, 2009/08/27
- Re: [PATCH] Miscellaneous code readability improvements., Eric Blake, 2009/08/27
- Re: [PATCH] Miscellaneous code readability improvements., Joel E. Denny, 2009/08/27
- Re: [PATCH] Miscellaneous code readability improvements.,
Eric Blake <=
- Re: [PATCH] Miscellaneous code readability improvements., Joel E. Denny, 2009/08/28
- Re: [PATCH] Miscellaneous code readability improvements., Eric Blake, 2009/08/28
- Re: [PATCH] Miscellaneous code readability improvements., Joel E. Denny, 2009/08/29