Re: [bongo-devel] Re: Marks

[Daniel Brockman]

Daniel Brockman <address@hidden> writes:

> address@hidden (Daniel Jensen) writes:
>
>> Daniel Brockman <address@hidden> writes:
>>
>>> Daniel Brockman <address@hidden> writes:
>>>
>>>> The `* *' command toggles between a set of marks and the
>>>> empty set of marks. [...]
>>>
>>> I implemented this.
>>
>> Looks nice, though I haven't done any extensive testing.
>>
>> When you kill marked tracks, `bongo-toggle-marking' does not
>> know about it. It should, otherwise weird things might happen.
>
> Good catch.  I'll install a fix.

I installed a large change that, I believe, fixes this.
Since this part of the code is known to be buggy I just
went ahead and installed this even though it was large
and involved deep changes to the marking code.

>> I am a little confused with `bongo-unmark-all'. Is it
>> really a good thing that it does not store a marking?
>
> I don't know --- maybe not.  How about renaming it to
> `bongo-kill-marking' and moving it to `* k'?  Then we
> can add `* y' and `* w' and move to a stack if needed.

I added `bongo-kill-marking' and `bongo-yank-marking',
and made `bongo-toggle-marking' a simple wrapper around
those two commands.  However, `bongo-unmark-all' is still
bound to `U' and still does not save the marking.

Do you think we should rebind `U' to `bongo-kill-marking'?

-- 
Daniel Brockman <address@hidden>